fix: debugger_class in ultratb #13498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
reviewed
Feb 1, 2022
IPython/core/ultratb.py
Outdated
| @@ -907,7 +907,7 @@ def debugger(self, force: bool = False): | |||
| fix that by hand after invoking the exception handler.""" | |||
|
|
|||
| if force or self.call_pdb: | |||
| if self.pdb is None: | |||
| if self.debugger_cls: | |||
| self.pdb = self.debugger_cls() | |||
There was a problem hiding this comment.
I don't think this is totally correct. pdb is supposed to be the instance, there is just another place that sets pdb without respecting debugger_cls.
There was a problem hiding this comment.
there is just another place that sets pdb without respecting debugger_cls
which place exactly? ListTB?
There was a problem hiding this comment.
Sorry coming back to this.
Here in init:
ipython/IPython/core/ultratb.py
Lines 231 to 234 in 781e675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13495