Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expiry days option to pastebin magic and change http protocol to https #13056

Merged
merged 8 commits into from Jul 15, 2021

Conversation

eyenpi
Copy link
Contributor

@eyenpi eyenpi commented Jul 13, 2021

I just added an option to determine the number of days for paste expiration.
Also, change the protocol of the dpaste API from HTTP to HTTPS.
#12968

@MrMino
Copy link
Member

MrMino commented Jul 13, 2021

@eyenpi cool, it just requires a little bit of darkening (reformatting). See the logs.

I'll review the code after the pipeline passes. Thanks!

IPython/core/magics/code.py Outdated Show resolved Hide resolved
IPython/core/magics/code.py Outdated Show resolved Hide resolved
IPython/core/magics/code.py Outdated Show resolved Hide resolved
Copy link
Member

@MrMino MrMino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks great, there are only few very minor kinks to get this in. Oh, and also, please add a what's new entry for this.

eyenpi and others added 4 commits July 14, 2021 14:08
Co-authored-by: Blazej Michalik <6691643+MrMino@users.noreply.github.com>
Co-authored-by: Blazej Michalik <6691643+MrMino@users.noreply.github.com>
"Title underline too short."
@MrMino
Copy link
Member

MrMino commented Jul 15, 2021

@eyenpi thank you, nice PR! Hopefully it's the first of many :).

@MrMino MrMino merged commit b3355a9 into ipython:master Jul 15, 2021
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request Jul 15, 2021
MrMino added a commit that referenced this pull request Jul 20, 2021
…056-on-7.x

Backport PR #13056 on branch 7.x (add expiry days option to pastebin magic and change http protocol to https)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants