Make Ipython.utils.timing work with jupyterlite #13050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JupyterLite has a resource, but not getrusage(). This make the code a little more general.
|
I'm not sure if I understand why this needs to be so - could you please elaborate the description? I haven't used jupyterlite yet, much less read through its code. |
|
Sure! The code was previously written so that it would check to see if it could import Thanks for the review! |
|
Thanks both ! Merging this and releasing soon. |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jul 31, 2021
Carreau
added a commit
that referenced
this pull request
Jul 31, 2021
…050-on-7.x Backport PR #13050 on branch 7.x (Make Ipython.utils.timing work with jupyterlite)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JupyterLite has a resource, but not getrusage(). This make the code a little more general.