Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of deprecated pipes module #12932

Merged
merged 2 commits into from Apr 30, 2021
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 30, 2021

pipes.quote is actually an alias to shlex.quote, so use its true name instead

pipes is (probably) deprecated by PEP 594, to be removed possibly in 3.10.

pipes.quote is actually an alias to shlex.quote

deprecated by PEP 594, to be removed in 3.10
@MrMino
Copy link
Member

MrMino commented Apr 30, 2021

Weird. Why is darker linting IPython/core/magics/script.py?

Run darker -r 60625f241f298b5039cb2debc365db38aa7bb522 --check --diff . || (
--- IPython/core/magics/script.py
+++ IPython/core/magics/script.py
@@ -213,7 +213,7 @@
                     *cmd,
                     stdout=asyncio.subprocess.PIPE,
                     stderr=asyncio.subprocess.PIPE,
-                    stdin=asyncio.subprocess.PIPE
+                    stdin=asyncio.subprocess.PIPE,
                 )
             )
         except OSError as e:
Changes need auto-formatting. Run:
    darker -r 60625f241f298b5039cb2debc365db38aa7bb522
then commit and push changes to fix.
Error: Process completed with exit code 1.

@Carreau
Copy link
Member

Carreau commented Apr 30, 2021

LIkely because it lints all the differences since commit 60625f2, and the recently new version of black had a few changes.

@Carreau Carreau modified the milestones: 8.0, 7.23 Apr 30, 2021
@Carreau Carreau merged commit bbd5c45 into ipython:master Apr 30, 2021
@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Apr 30, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 7.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 bbd5c45aec2f16e960f527dcc91c7d3bf4d88369
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12932: remove use of deprecated pipes module'
  1. Push to a named branch :
git push YOURFORK 7.x:auto-backport-of-pr-12932-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #12932 on branch 7.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app bot added the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label Apr 30, 2021
Carreau added a commit to Carreau/ipython that referenced this pull request Apr 30, 2021
Carreau added a commit that referenced this pull request Apr 30, 2021
Backport PR #12932: remove use of deprecated pipes module
@ivanov ivanov removed the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants