dpaste.com API correction #12712
Merged
dpaste.com API correction #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, one build failed, but I can't see that it's related to my changes. SQLite is complaining about attempted writes to a read-only DB, which leads to: I see one other recent PR build with what looks like the same problem. Help? |
|
Thanks you very much, and congrats on your first PR, apologies the last few month have been busy and I need to catch up with all the recent issues and code suggestion. Yours looks good, when I have more time I'll test it locally and merge it; Thanks ! |
Carreau
force-pushed
the
dpaste-api-correction
branch
from
5bcd581
to
9427eb2
Compare
|
Failures seem completely unrelated, thanks a lot for running dpast.com and any trouble we might have caused you. |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Mar 26, 2021
Carreau
added a commit
that referenced
this pull request
Mar 27, 2021
…712-on-7.x Backport PR #12712 on branch 7.x (dpaste.com API correction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello good people of IPython!
I run dpaste.com, which IPython uses via the
%pastebinmagic. In July I updated my Pygments version, which caused thepython3syntax key that IPython uses to disappear. I special-cased this on my end so that users wouldn't hit an error, but this PR fixes it at the source.(TLDR on the syntax name change on the Pygments end:
pythonbecamepython2, andpython3becamepython.)I also added a UA header to the request, to comply with the "automated use" section of the dpaste.com TOS (though the
%pastebinmagic is more "semi-automated" than automated really).This is my first IPython PR. I've read the contributor guidelines and believe I'm following expected workflow, but please let me know if more is needed (e.g. if I should create an Issue to track this). I don't have a local development instance of IPython, so apologies if the Travis build triggered by this PR finds some dumb error. I'll fix any such.