fix getting signatures in jedi 0.17

[Carreau]

No description provided.

[Carreau]

@davidhalter does that looks reasonable to you ? Or is there a cleaner way ?

[davidhalter]

Looks reasonable, but I would handle the case of get_signatures() == [] as well. This makes it easier in the future, so you don't have to depend on type (which was a bad idea in the first place - my fault).

[Carreau]

Thanks ! Hope all is well for you.

[davidhalter]

Probably not intentional :)

Otherwise, LGTM.

[Carreau]

Doh.. force-pushed.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 7.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 48b4dd063a1c58a8af28953392a285063cfdb7ce

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #12255: fix getting signatures in jedi 0.17'

4. Push to a named branch :

git push YOURFORK 7.x:auto-backport-of-pr-12255-on-7.x

5. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #12255 on branch 7.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[Carreau]

actually no need to backport, 7.x still use completions() and not complete()