Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all_completions use new completion code #11591

Merged
merged 2 commits into from Feb 18, 2019
Merged

Make all_completions use new completion code #11591

merged 2 commits into from Feb 18, 2019

Conversation

memeplex
Copy link
Contributor

@memeplex memeplex commented Feb 4, 2019

This fixes a bug affecting emacs users introduced by 7.2.

Fixes #11541

memeplex and others added 2 commits February 4, 2019 14:05
@memeplex
Make all_completions use new completion code
3b7e5cc 
This fixes a bug affecting emacs users introduced by 7.2.

Fixes #11541
@Carreau
Fix api compatibility.
75dc1c0 
Wrap into the with provisionalCompleter() and return a list instead of
an iterator just in case.

Also add types hints.
@Carreau
Copy link
Member

Carreau commented Feb 5, 2019

Thanks, I added one commit :

   Fix api compatibility.

    Wrap into the with provisionalCompleter() and return a list instead of
    an iterator just in case.

    Also add types hints.

Sounds good otherwise.

@memeplex
Copy link
Contributor Author

memeplex commented Feb 6, 2019 •
edited

I think this can be merged.

@Carreau Carreau merged commit 6e1eff6 into ipython:master Feb 18, 2019
@Carreau Carreau added this to the 7.3 milestone Feb 18, 2019
@Carreau
Copy link
Member

Carreau commented Feb 18, 2019

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

all_completions returns nothing (simple fix suggested)
2 participants
@memeplex @Carreau