Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ipykernel align kernel SVG with the one used by JupyterLab? #1183

Open
krassowski opened this issue Dec 20, 2023 · 0 comments
Open

Should ipykernel align kernel SVG with the one used by JupyterLab? #1183

krassowski opened this issue Dec 20, 2023 · 0 comments

Comments

@krassowski
Copy link
Member

As per discussion in JupyterLab there seems to be a consensus to propose that ipykernel switches the svg icon to the one used in JupyterLab. Originally reported and discussed in jupyterlab/jupyterlab#13991, included below for convenience:

Description

The buttons for launching a notebook with the Python kernel and for creating a new Python file both use a Python icon, but they look different. It is best to stick to one or the other to preserve consistency in the UI. This is of special significance given that this is what most users see first when launching JL.

Screen Shot 2023-02-13 at 2 27 59 PM

Reproduce

  1. Open JupyterLab
  2. Observe the Python icons are different

Expected behavior

The icons should be the same.

Context

  • Operating System and version: OS X Monterey
  • Browser and version: Chrome 109.0.5414.119 (Official Build) (x86_64)
  • JupyterLab version: 4.0.0a33 binder

I believe I had discussed this earlier when working on my CSS PR (now sadly abandoned). If I recall, the Python icons used at the top are actually coming from the kernel and are not hard-coded in the JL frontend. Would appreciate additional context from anybody knowledgable on this.

Originally posted by @dlqqq in jupyterlab/jupyterlab#13991 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant