Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep on traitlet #15

Open
vincent-grosbois opened this issue Aug 2, 2023 · 2 comments
Open

Remove dep on traitlet #15

vincent-grosbois opened this issue Aug 2, 2023 · 2 comments

Comments

@vincent-grosbois
Copy link
Contributor

Hi!
as we discovered, the dependency on traitlet >= 5 means that actually, the comm project requires python >= 3.7 contrary to what is published (claims to support python 3.6)

I've seen that the traitlet dependency is used just in order to import this : https://github.com/ipython/traitlets/blob/main/traitlets/utils/importstring.py , which is pretty stable and easy

I suggest to just copy the method in comm package and remove the dep on traitlet all-together
what do you think ?

@vincent-grosbois
Copy link
Contributor Author

Or otherwise, if it's simpler, we can losen the dependency as you suggested : #16

@martinRenou
Copy link
Collaborator

Thank you for doing this, I triggered the release it should come soon.

Concerning the removal of traitlets, we may want to consider this later indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants