Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define metadata type for Trustless HTTP Gateway Multicodec #21

Closed
hannahhoward opened this issue Apr 21, 2023 · 2 comments · Fixed by #22
Closed

Define metadata type for Trustless HTTP Gateway Multicodec #21

hannahhoward opened this issue Apr 21, 2023 · 2 comments · Fixed by #22

Comments

@hannahhoward
Copy link

What

Define a metadata type for the new multicodec defined here multiformats/multicodec#321, support records publishing for this metadata type

Implementation

My suggestion is for the time being, this metadata should simply be an empty struct until we identify any additional parameters required. The codec isn't really finished until ipfs/specs#402 is merged, and I expect more things to change before it is.
@hannahhoward hannahhoward mentioned this issue Apr 21, 2023
Open
12 tasks
@willscott
Copy link
Member

agree it can be empty - the same as the current bitswap behavior.
for that, i don't believe any particular change is needed to support it, though we can provide a nice name in https://github.com/ipni/go-libipni/tree/main/metadata rather than making users use the unknown fallback wrapper.

@hannahhoward
Copy link
Author

That'd be great!

masih added a commit that referenced this issue Apr 24, 2023
@masih
Add IPFS Gateway HTTP transport metadata as a well-known multicodec
ca2d8c4 
Add SDK to aid parsing IPNI metadata that represents IPFS Gateway HTTP
transport protocol.

Relates to:
 - multiformats/multicodec#321

Fixes #21
@masih masih mentioned this issue Apr 24, 2023
Merged
masih added a commit that referenced this issue Apr 24, 2023
@masih
Add IPFS Gateway HTTP transport metadata as a well-known multicodec
e20eabc 
Add SDK to aid parsing IPNI metadata that represents IPFS Gateway HTTP
transport protocol.

Relates to:
 - multiformats/multicodec#321

Fixes #21
@masih masih closed this as completed in #22 Apr 25, 2023
masih added a commit that referenced this issue Apr 25, 2023
@masih
Add IPFS Gateway HTTP transport metadata as a well-known multicodec
d2811a7 
Add SDK to aid parsing IPNI metadata that represents IPFS Gateway HTTP
transport protocol.

Relates to:
 - multiformats/multicodec#321

Fixes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add IPFS Gateway HTTP transport metadata as a well-known multicodec ipni/go-libipni
2 participants
@willscott @hannahhoward