Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress tracker for index creation #351

Open
aschmahmann opened this issue Jan 16, 2023 · 2 comments
Open

Progress tracker for index creation #351

aschmahmann opened this issue Jan 16, 2023 · 2 comments
Assignees
Labels
P3 Low: Not priority right now

Comments

@aschmahmann
Copy link
Contributor

Index creation can be very expensive for large CARs and it'd be nice to be able to track (and in the CLI emit) progress as it's being generated.

If

func LoadIndex(idx index.Index, r io.Reader, opts ...Option) error {
took a context I'd probably recommend attaching the tracker there (and probably also allowing the caller to bail via context cancellation). We could potentially put it into the Options struct, but I don't know if that fits the model of what that struct is aiming for.

Any suggestions on acceptable API modifications (or new function introductions) here?

@willscott
Copy link
Member

I think somewhere else we tracked progress by knowing the total length of the reader and tracking how much had been read so far.

Can you do it that way?

@BigLep BigLep added the P3 Low: Not priority right now label Mar 28, 2023
@BigLep
Copy link
Contributor

BigLep commented Mar 28, 2023

During IPLD triage: do you need more input here @aschmahmann ? Do you think you'll proceed with this change?

@BigLep BigLep added the need/author-input Needs input from the original author label Mar 28, 2023
@BigLep BigLep removed the need/author-input Needs input from the original author label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants