Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexes don't take advantage of performant structure #285

Open
willscott opened this issue Jan 20, 2022 · 3 comments
Open

Indexes don't take advantage of performant structure #285

willscott opened this issue Jan 20, 2022 · 3 comments
Labels
P3 Low: Not priority right now

Comments

@willscott
Copy link
Member

The common form of Index introduced in Car V2 is to lay out the CIDs in the car in a sorted table that can be quickly walked through with a binary search.

We should attempt to optimize not fully copying the index into memory when loading a car, and just doing spot reads from the index. This can for large cars avoid a copy of hundreds of megs per individual block read.

@mvdan
Copy link
Contributor

mvdan commented Jan 20, 2022

Dupe of #243 or #95, perhaps. We already have multiple issues that all boil down to: we should be able to consume some index formats directly from disk.

@willscott
Copy link
Member Author

yep, happy to dupe, maybe this is more trying to indicate that this remains one of our expected performance bottle necks that we shouldn't lose track of

@aarshkshah1992
Copy link
Contributor

Would be GREAT to have for filecoin-project/dagstore#116.

@rvagg rvagg added the P3 Low: Not priority right now label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

4 participants