Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carv2.NewBlockReader cannot be used with a stream #282

Open
willscott opened this issue Jan 13, 2022 · 1 comment
Open

carv2.NewBlockReader cannot be used with a stream #282

willscott opened this issue Jan 13, 2022 · 1 comment

Comments

@willscott
Copy link
Member

NewBlockReader takes an io.Reader, however when passed os.Stdin with a carv2 payload, the call to new will error with "seek /dev/stdin: illegal seek"

It's unclear how this is trying to seek on an io.Reader in the first place.
@mvdan
Copy link
Contributor

mvdan commented Jan 13, 2022

Oops, that sounds like at least an oversight.

@willscott willscott mentioned this issue Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willscott @mvdan