Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden car cli extract command against symlink traversal attacks #264

Open
willscott opened this issue Nov 15, 2021 · 0 comments
Open

harden car cli extract command against symlink traversal attacks #264

willscott opened this issue Nov 15, 2021 · 0 comments
Labels
P2 Medium: Good to have, but can wait until someone steps up

Comments

@willscott
Copy link
Member

it may be possible for a malformed car to specify a symlink, and then later in the same directory specify another entry with the same name, that could then be written into the destination of the symlink.

This should already be safe - since the final destination path is resolved and required to be within the extraction directory, but testing is needed to ensure these edge cases are properly caught as errors.

@BigLep BigLep added the P2 Medium: Good to have, but can wait until someone steps up label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants