Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Block and CAR response types #270

Closed
lidel opened this issue Jul 25, 2022 · 1 comment
Closed

Test Block and CAR response types #270

lidel opened this issue Jul 25, 2022 · 1 comment
Assignees
@whizzzkid
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Jul 25, 2022

We should add tests for trustless (verifiable) response types: application/vnd.ipld.raw and application/vnd.ipld.car

Should have tests for requesting both ?format=raw|car and Accept: application/vnd.ipld.raw|car and passing only when both work.

Ref.
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up labels Jul 25, 2022
@lidel lidel removed the good first issue Good issue for new contributors label Aug 1, 2022
@whizzzkid whizzzkid self-assigned this Oct 11, 2022
@whizzzkid whizzzkid mentioned this issue Oct 12, 2022
Merged
@whizzzkid
Copy link
Contributor

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @whizzzkid