Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharness: use deterministic fixtures during gateway testing #9654

Closed
5 tasks done
laurentsenta opened this issue Feb 17, 2023 · 2 comments · Fixed by #9667
Closed
5 tasks done

sharness: use deterministic fixtures during gateway testing #9654

laurentsenta opened this issue Feb 17, 2023 · 2 comments · Fixed by #9667
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@laurentsenta
Copy link
Contributor

laurentsenta commented Feb 17, 2023

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

This request was raised by @lidel in ipfs/gateway-conformance#2 (comment)

We are now asking IPIPs writers to provide static fixtures (CARs) files which means it's possible to create deterministic test suites, and we don't need to exercise unrelated parts of the codebase during the test (ipfs add, etc). We plan on using this approach in the gateway conformance testing work.

To validate this approach and make the transition smoother, we will upgrade the current sharness tests to use static test fixtures.

Outcomes:

  • Every gateway-related test relies on static car files and ipfs dag import instead of generating data at runtime
  • Every gateway-related test relies on deterministic ipns fixtures as well

I'll take some time to look into #7804 at the same time.

@laurentsenta laurentsenta added the kind/enhancement A net-new feature or improvement to an existing feature label Feb 17, 2023
@laurentsenta laurentsenta changed the title sharness: use deterministic fixtures during testing sharness: use deterministic fixtures during gateway testing Feb 17, 2023
@laurentsenta laurentsenta self-assigned this Feb 17, 2023
@laurentsenta
Copy link
Contributor Author

note: static ipns fixtures might relates to ipfs/specs#369 and the IPFS_NS_MAP (for DNS link)

@laurentsenta
Copy link
Contributor Author

laurentsenta commented Mar 10, 2023

PR for static ipns fixtures is implemented in: #9667

Issues:

Note:

  • ipfs routing put /ipns/KEY ./record.ipns prints the SELF key, even though the record might contain a different key. It should print the key that was publish to the routing system (KEY)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant