Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more Metrics Optin #9290

Open
Jorropo opened this issue Sep 21, 2022 · 0 comments
Open

Make more Metrics Optin #9290

Jorropo opened this issue Sep 21, 2022 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@Jorropo
Copy link
Contributor

Jorropo commented Sep 21, 2022 •
edited

Go-libp2p v0.23.0 added WithMetrics options to tcp and quic.
Right now we always add thoses to stay consistent with the old behaviour.

This should be optin in the kubo config because this has a somewhat big performance impact.

Go related metrics with prometeus are now also configurable: prometheus/client_golang#1102
@Jorropo Jorropo added the need/triage Needs initial labeling and prioritization label Sep 21, 2022
@Jorropo Jorropo changed the title Make transport Metrics Optin Make more Metrics Optin Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jorropo