Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch migration fetcher to CAR #8851

Closed
lidel opened this issue Apr 6, 2022 · 1 comment
Closed

Switch migration fetcher to CAR #8851

lidel opened this issue Apr 6, 2022 · 1 comment
Assignees
@Jorropo
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Milestone
Best Effort Track

Comments

@lidel
Copy link
Member

lidel commented Apr 6, 2022 •
edited

go-ipfs 0.13 will add support for CAR responses (#8758)

When we have that running on the ipfs.io gateway, we should update HttpFetcher to fetch CARs instead of trusting gateway to send the correct bytes.

This will enable us to add more public gateway as a fallback in case DNS name gets censored etc without risking MITM.

The default gateways list should be ipfs.io, dweb.link, cloudflare-ipfs.com, cf-ipfs.com (+ make sure HTTP redirects are followed by the fetcher). We could also have the ultimate fallback which downloads https://github.com/ipfs/public-gateway-checker/raw/master/src/gateways.json and tries them too.
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week labels Apr 6, 2022
@lidel lidel added this to the Best Effort Track milestone Apr 6, 2022
@lidel lidel mentioned this issue Apr 6, 2022
Merged
@lidel lidel mentioned this issue Apr 25, 2022
Open
@hacdias hacdias mentioned this issue Sep 5, 2022
Closed
@BigLep BigLep mentioned this issue Nov 17, 2022
Closed
@lidel
Copy link
Member Author

lidel commented May 16, 2023

Continued in #9159

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jorropo Jorropo

Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

feat: download migrations using car files ipfs/kubo
2 participants
@lidel @Jorropo