Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we want to keep this interface as []string, #10336

Closed
alexandrabeasley8 opened this issue Feb 8, 2024 · 3 comments
Closed

do we want to keep this interface as []string, #10336

alexandrabeasley8 opened this issue Feb 8, 2024 · 3 comments
Labels
kind/stale need/author-input Needs input from the original author

Comments

@alexandrabeasley8
Copy link

https://github.com/ipfs/kubo/blob/f4ff4f76dd0d54b7a9da1fa1ac64b163ea3d3a18/client/rpc/pubsub.go#L1-L214
@aschmahmann
Copy link
Contributor

What's your concern/does it matter? We could convert it to []byte although I'm not sure if that would really make things easier for anyone and would change the public API.

@lidel lidel added the need/author-input Needs input from the original author label Apr 16, 2024
@github-actions GitHub Actions
Copy link

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

This issue was closed because it is missing author input.

@github-actions github-actions bot closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/stale need/author-input Needs input from the original author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @aschmahmann @alexandrabeasley8