This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: add onError to pubsub.subscribe types #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in #3468. Also runs the type checker on the pubsub http client tests to ensure typing is correct.
achingbrain
changed the title
|
Types are failing - they've been broken by DefinitelyTyped/DefinitelyTyped#52776 (review) but will be fixed by DefinitelyTyped/DefinitelyTyped#53591 |
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
This was missed in #3468. Also runs the type checker on the pubsub http client tests to ensure typing is correct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #3468. Also runs the type checker on the pubsub http client tests to ensure typing is correct.