Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert to typescript #5

Merged
merged 7 commits into from Dec 9, 2021
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Dec 3, 2021

There's a bunch of lint warnings, but it would require bigger changes to resolve (and were probably pre-existing). I vote we do that in a separate PR to keep this one small.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small things

src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 7dcfca6 into ipfs:master Dec 9, 2021
@alanshaw alanshaw deleted the refactor/ts branch February 21, 2022 14:12
@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants