Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 fails to build with the latest go: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration #104

Closed
yurivict opened this issue Mar 29, 2022 · 9 comments
Labels
effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@yurivict
Copy link

github.com/lucas-clemente/quic-go/internal/qtls
# github.com/lucas-clemente/quic-go/internal/qtls
vendor/github.com/lucas-clemente/quic-go/internal/qtls/go118.go:6:13: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

OS: FreeBSD 13

@yurivict yurivict added the need/triage Needs initial labeling and prioritization label Mar 29, 2022
@welcome
Copy link

welcome bot commented Mar 29, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@aschmahmann
Copy link
Contributor

https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions

Basically, this can get resolved once go-ipfs updates to a version of QUIC that supports 1.18. See the link for more details.

@yurivict
Copy link
Author

Any chance to resolve this? Currently ipget fails to build with the latest version of Go.

@yurivict
Copy link
Author

go-ipfs is at 0.12.2, but ipget still uses 1.11

@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels May 16, 2022
@lidel
Copy link
Member

lidel commented May 16, 2022

latest go-ipfs 0.13-rc1 builds fine with golag 1.18, so if someone wants to work on this:

  • ipget needs to be updated at least to that version of go-ipfs, and also bump go-libp2p to 0.19 or later

@lidel lidel added this to the Best Effort Track milestone May 16, 2022
@yurivict
Copy link
Author

0.8.1 still has this problem.

I think I should just remove the port because the project is broken for months.

@dmgk
Copy link

dmgk commented Jun 17, 2022

Polite ping. go-ipfs currently is at v0.13.0, and builds fine with go1.18.

@Stebalien
Copy link
Member

This will be fixed by #110. Unfortunately, that's blocked on ipfs/go-ipfs-http-client#160.

@lidel
Copy link
Member

lidel commented Jun 24, 2022

Should be fixed in v0.9.x: https://dist.ipfs.io/ipget

@lidel lidel closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants