Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Open in Gateway #1814

Closed
FledgeXu opened this issue Jul 2, 2021 · 5 comments
Closed

Feature: Add Open in Gateway #1814

FledgeXu opened this issue Jul 2, 2021 · 5 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@FledgeXu
Copy link
Contributor

FledgeXu commented Jul 2, 2021

Is your feature request related to a problem? Please describe.
In #1813, the user wants a feature which is showing the downloading progress in the WebUI. However, If users can download through the browser, they can get the download progress they want. So if we can add a new Button called Open in Gateway orOpen in Browser, it will be convenient.

Describe the solution you'd like
Before:
image
After:
image

Describe alternatives you've considered
Or Add a Button to help users copy the gateway URL of a file.

Additional context
We can use ipfs config Addresses.Gateway to get Gateway address.

@FledgeXu FledgeXu added the need/triage Needs initial labeling and prioritization label Jul 2, 2021
@lidel
Copy link
Member

lidel commented Jul 2, 2021

Notes from triage:

  • let's not add another action, it will be confusing (proposed one is a duplicate of Share)
  • right now the Download button uses JS API and a blob: as a source
  • fix here is to switch to HTTP link at a local gateway
    • single file would have /ipfs/{cid}?filename=foo&download=true to ensure proper `content-disposition
    • a directory – tbd, either /api/v0/ or ?format=tar (whichever is available when this is tackled)

@lidel lidel added exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Jul 2, 2021
@FledgeXu
Copy link
Contributor Author

FledgeXu commented Jul 3, 2021

I agree with changing the Download button instead of adding a new action.
About directory downloading,?format=tar needs ipfs/kubo#8234. However, Windows doesn't support tar unarchive. Maybe using zip is a better choice?

@lidel
Copy link
Member

lidel commented Jul 30, 2021

@FledgeXu You mean GUI? Support for tar has been included in Microsoft Windows since Windows 10:
https://techcommunity.microsoft.com/t5/containers/tar-and-curl-come-to-windows/ba-p/382409

Adding ZIP would require changes to go-ipfs – blocked by ipfs/kubo#6104

@FledgeXu
Copy link
Contributor Author

@lidel Yes, I just tested it. Windows still doesn't support the *.tar in GUI.
image

@SgtPooki
Copy link
Member

I believe this should be fixed with #1894. Please let us know if you continue to have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants