Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user when trying to download where they dont have the full tree locally #1692

Open
olizilla opened this issue Nov 22, 2020 · 2 comments
Labels
area/screen/files Issues related to Files screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P3 Low: Not priority right now

Comments

@olizilla
Copy link
Member

Describe the bug
"Download" gets stuck when you dont have the full tree locally and you are unable to fetch it. Even if you are able to fetch it the download may take a while and appear to stall as the user does not know they are know waiting to find the blocks.

We can check to see if the full tree is available locally before starting the download and warn that we will have to go find the full tree and it could take a while if it isn't all available.

This is easy to trigger know due to the "Import from IPFS" action only importing the root block as per #1691

@olizilla olizilla added the need/triage Needs initial labeling and prioritization label Nov 22, 2020
@jessicaschilling jessicaschilling added area/screen/files Issues related to Files screen exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization status/ready Ready to be worked labels Nov 23, 2020
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Nov 23, 2020

From today's triage discussion: Actually implementing a fix shouldn't be too difficult, but need some further investigation first, to wit:

  • Determine how expensive it is to tell if an item is available locally or not
  • Determine if we (and if so, how expensive is it) can get a percentage of an item that's available locally

If it's expensive:

  • Check only at time of download, and if the item isn't fully available locally, give a warning modal that we have to find the full tree and that might take a while if it's not all available

If it's not expensive:

  • Add a UI element in the Files screen table to indicate whether an item is fully local or not (perhaps including percentage local availability)

As of time of writing, bandwidth doesn't support our swarming on getting this fixed, but let's keep close to the top of our "quick fixes" priority list.

@SgtPooki
Copy link
Member

SgtPooki commented Dec 2, 2022

We need to repro after merging #1894

@SgtPooki SgtPooki added P3 Low: Not priority right now and removed P1 High: Likely tackled by core team if no one steps up labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P3 Low: Not priority right now
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

3 participants