Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: race condition in @helia/ipns->dns resolvers->default should abort if signal is aborted #385

Open
SgtPooki opened this issue Jan 16, 2024 · 0 comments
Open

bug: race condition in @helia/ipns->dns resolvers->default should abort if signal is aborted #385

SgtPooki opened this issue Jan 16, 2024 · 0 comments
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@SgtPooki
Copy link
Member

default should abort if signal is aborted failed during a job: https://github.com/ipfs/helia/actions/runs/7545440173/job/20541106692?pr=384#step:5:141

@helia/ipns: npm run test:chrome-webworker
# ...
@helia/ipns:   1) dns resolvers
@helia/ipns:        default should abort if signal is aborted:
@helia/ipns:      AssertionError: expected promise to be rejected but it was fulfilled with '/ipfs/QmVAvbnR2M7jTPfU3fQK12VfYPYqcGJ…'

assuming it's a race condition because re-run succeeded: https://github.com/ipfs/helia/actions/runs/7545440173/job/20548725299?pr=384
@SgtPooki SgtPooki added P2 Medium: Good to have, but can wait until someone steps up dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/test Testing work status/ready Ready to be worked labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki