Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs2 block put should read stdin (current reads file arg) #305

Closed
btc opened this issue Nov 12, 2014 · 3 comments
Closed

ipfs2 block put should read stdin (current reads file arg) #305

btc opened this issue Nov 12, 2014 · 3 comments

Comments

@btc
Copy link
Contributor

btc commented Nov 12, 2014

working on fix

tagging @jbenet to ensure the statement in the title is true

@btc btc self-assigned this Nov 12, 2014
@btc btc added this to the merge commands milestone Nov 12, 2014
@jbenet
Copy link
Member

jbenet commented Nov 12, 2014

ipfs2 block put should read stdin

Correct.

@btc btc removed their assignment Nov 13, 2014
@mappum
Copy link
Contributor

mappum commented Nov 14, 2014

Stdin handling provided in f3e43a4.
This reads stdin as a reader if the argument is an ArgFile (so cat foo.txt | ipfs block put will work), and reads it as a string if the argument is an ArgString (ipfs name resolve | ipfs cat works).

@mappum
Copy link
Contributor

mappum commented Nov 14, 2014

Resolved in 118b084

@mappum mappum closed this as completed Nov 14, 2014
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants