Ipns Consistency #296
Merged
Ipns Consistency #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "ImportPath": "github.com/jbenet/go-ipfs", | |||
| "GoVersion": "go1.3", | |||
| "GoVersion": "devel +9340f9f6dfc9 Fri Oct 31 00:48:57 2014 -0300", | |||
|
Great PR, as always. A few codebase-friendliness comments up there, but all this LGTM! |
whyrusleeping
force-pushed
the
consistency
branch
from
5cfe20a
to
9301e61
Compare
|
@jbenet am i good to merge? |
|
@whyrusleeping depends, did the commands merge change anything here? we've officially deprecated |
|
If you merged over the ipfs name code then no, nothing should have changed. |
?? |
|
I mean, if you've ported over the code for |
|
those have been ported |
|
I'm going to rebase this on top of new master first. |
test(time) expose time format var License: MIT Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
|
|
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
When a peer is found, add its addr to the peerstore, just like the addresses for closer peers are added. In particular this is helpful for followup queries by the DHT user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the DHT so that it stores records instead of simple values. This allows us to add a layer of security onto the DHT, and also allows us to validate values that are stored in it.
Currently, only two value types are allows to be stored in the DHT:
Other types of Ipns Validity functions should be discussed, as only one is implemented. More complex checks may require a change in how the validity functions are called (maybe add new parameters, etc).