This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix(arc): striped locking on last byte of CID #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
from
cedc5bc
to
a6bac41
Compare
Closed
frrist
force-pushed
the
frrist/arc-cache-bench
branch
2 times, most recently
from
11498f4
to
80e1a84
Compare
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
from
a6bac41
to
2815f62
Compare
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
2 times, most recently
from
878e3f9
to
d94af12
Compare
2 tasks
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
from
d94af12
to
66266c5
Compare
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
2 times, most recently
from
83cb480
to
72ade3e
Compare
Stebalien
suggested changes
May 4, 2021
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
from
9d57a70
to
b34f205
Compare
frrist
commented
May 4, 2021
arc_cache.go
Outdated
| var good []blocks.Block | ||
| for _, block := range bs { | ||
| // call put on block if result is inconclusive or we are sure that | ||
| // the block isn't in storage | ||
| if has, _, ok := b.queryCache(block.Cid()); !ok || (ok && !has) { | ||
| if !block.Cid().Defined() { | ||
| log.Error("undefined cid in arc cache") | ||
| continue |
There was a problem hiding this comment.
unsure if we want to continue or bail in the event an undefined CID is in bs, thoughts?
There was a problem hiding this comment.
On put, bail. This is definitely an invalid block.
There was a problem hiding this comment.
removed this case since it should never (right?) be the case that the CID of a blocks.Block is undefined.
There was a problem hiding this comment.
Yeah, that should be impossible.
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
3 times, most recently
from
b305189
to
7475315
Compare
Stebalien
suggested changes
May 4, 2021
Stebalien
suggested changes
May 4, 2021
frrist
force-pushed
the
frrist/arc-cache-stripe
branch
from
fe0c977
to
8d1f7bf
Compare
Stebalien
approved these changes
May 4, 2021
|
Thanks! |
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…che-stripe fix(arc): striped locking on last byte of CID This commit was moved from ipfs/go-ipfs-blockstore@d90561b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.