Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf vs dag-pb #75

Closed
alanshaw opened this issue Sep 20, 2018 · 2 comments
Closed

protobuf vs dag-pb #75

alanshaw opened this issue Sep 20, 2018 · 2 comments

Comments

@alanshaw
Copy link
Member

The name for 0x70 here is "protobuf":

go-cid/cid.go

Line 88 in 6e296c5

"protobuf": DagProtobuf,

In the multicodec table the name for 0x70 is defined as "dag-pb":
https://github.com/multiformats/multicodec/blob/master/table.csv#L408

"protobuf" exists in the table but is mapped to 0x50:
https://github.com/multiformats/multicodec/blob/master/table.csv#L30

This is creating an interop issue with /api/v0/block/put?format=dag-pb - it's not understood by go-ipfs.

Can this be fixed?

alanshaw added a commit to ipfs-inactive/js-ipfs-http-client that referenced this issue Sep 20, 2018
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@Stebalien
Copy link
Member

It doesn't look like these names map to that table. Other issues:

  1. "v0" is dag-pb with v0 CIDs (I think?)
  2. cbor should be dag-cbor.

We'll probably need to add aliases (like we do with "v0" and "protobuf").

@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@lidel
Copy link
Member

lidel commented Apr 4, 2024

I believe this was handled in #137 and https://github.com/ipfs/go-cid/releases/tag/v0.2.0

@lidel lidel closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants