Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we check how many peers there are when pinning? #762

Open
galargh opened this issue Sep 26, 2022 · 1 comment
Open

Should we check how many peers there are when pinning? #762

galargh opened this issue Sep 26, 2022 · 1 comment
Assignees
@galargh
Labels
effort/hours Estimated to take one or several hours P2 Medium: Good to have, but can wait until someone steps up team/ipdx

Comments

@galargh
Copy link
Contributor

galargh commented Sep 26, 2022 •
edited

We're waiting for 2 pin confirmations in https://github.com/ipfs/distributions/blob/master/scripts/ci/pin-to-cluster.sh#L21.

In https://github.com/ipfs/distributions/actions/runs/3126268124/jobs/5072181286 it was the case that there was only 1 peer in the peer_map so it was impossible to satisfy this requirement. I suggest we fail the job immediately if that's the case.

Discovered during ipfs/kubo#9237
@galargh galargh added need/triage Needs initial labeling and prioritization team/ipdx labels Sep 26, 2022
@galargh galargh self-assigned this Sep 26, 2022
@lidel
Copy link
Member

lidel commented Nov 28, 2022 •
edited

Failing fast when there are not enough cluster peers to have a minimum of 2 copies sgtm.

@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galargh galargh

Labels
effort/hours Estimated to take one or several hours P2 Medium: Good to have, but can wait until someone steps up team/ipdx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @galargh