Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Ipns.MaxCacheTTL #10321

Merged
merged 3 commits into from Jan 26, 2024
Merged

feat: add Ipns.MaxCacheTTL #10321

merged 3 commits into from Jan 26, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 25, 2024 •
edited

Closes ipfs/boxo#545.

@hacdias hacdias requested review from lidel and a team as code owners January 25, 2024 11:03
@hacdias hacdias self-assigned this Jan 25, 2024
@hacdias hacdias mentioned this pull request Jan 25, 2024
Merged
lidel
lidel reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added longer docs, lgtm, but rebase and check if CI is green first (it was stuck when I pushed my changes, so not sure if passing).

core/coreapi/coreapi.go Outdated Show resolved Hide resolved
@lidel lidel mentioned this pull request Jan 25, 2024
Closed
@hacdias hacdias merged commit 0ea879b into master Jan 26, 2024
18 checks passed
@hacdias hacdias deleted the ipns-maxcachettl branch January 26, 2024 10:20
@lidel lidel mentioned this pull request Feb 8, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipns: only use cache for prefetching then do confirmation with actual dht
2 participants
@hacdias @lidel