fix: uploading bundlesize artifact uses invalid character with namespaced modules #868
+21,759
−24,592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpetrunic please could you add a description with what is broken and how this fixes it? |
Sorry, updated description, I could swear I've filled in description |
achingbrain
changed the title
achingbrain
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bundle size github action. Action uploads bundle to github artifacts ans uses package name as artifact name. Unfortunately when you add this action to namespaced package, like '@chainsafe/libp2p-noise', action fails because "/" is illegal character for github artifact name.