feat: allow overriding runtime path for bundle size check #652
+48,436
−46,496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/opt-in-to-size-check
branch
2 times, most recently
from
d066906 to
84fb39f
Compare
achingbrain
changed the title
achingbrain
force-pushed
the
feat/opt-in-to-size-check
branch
4 times, most recently
from
f3f8635 to
34c5906
Compare
Not all modules built with aegir are destined to be consumed in a browser,
but as currently implemented the size check will run for every package in
a monorepo, which may then fail if one of those packages cannot be built
as a browser bundle - if it uses node core modules, for example.
The change here is to allow passing a directory path in which to run the
size check, this way monorepos can specify the modules they want tested
by using a build matrix:
```yaml
on:
pull_request:
branches:
- '*'
name: Bundlesize
jobs:
check:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x]
project:
- packages/module-1
- packages/module-2
- packages/etc
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Restore dependencies
id: cache-modules
uses: actions/checkout@v2
with:
path: node_modules
key: ${{ matrix.node-version }}-${{ runner.OS }}-build-${{ hashFiles('package.json') }}
- name: Install dependencies
run: npm install
- name: Bundlesize ${{ matrix.project }}
uses: ipfs/aegir/actions/bundle-size@feat/opt-in-to-size-check
with:
project: ${{ matrix.project }}
github_token: ${{ secrets.GITHUB_TOKEN }}
```
achingbrain
force-pushed
the
feat/opt-in-to-size-check
branch
from
abb635c to
a00f1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all modules built with aegir are destined to be consumed in a browser, but as currently implemented the size check will run for every package in a monorepo, which may then fail if one of those packages cannot be built as a browser bundle - if it uses node core modules, for example.
The change here is to allow passing a directory path in which to run the size check, this way monorepos can specify the modules they want tested by using a build matrix: