Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling button and then enabling doesn't restore style #16

Open
JeremiahChurch opened this issue Sep 22, 2019 · 5 comments
Open

Disabling button and then enabling doesn't restore style #16

JeremiahChurch opened this issue Sep 22, 2019 · 5 comments

Comments

@JeremiahChurch
Copy link
Contributor

JeremiahChurch commented Sep 22, 2019

If the disabled attribute is set to true and then disabled the style components for the slider (but not the thumb knob) are lost rather than restored to what they were before being disabled.

codesandbox demonstrating issue https://codesandbox.io/s/reverent-sky-89iip?fontsize=14

I cruised through the code and didn't see any immediate reason why this might happen. I'll dig in to this next week but wanted to create an issue in case the reason might be obvious to someone else.

Thank you!

@GarrickBrown
Copy link

Has there been any progress on this issue? Seems to still be occurring.

@JeremiahChurch
Copy link
Contributor Author

@GarrickBrown I never got to the core of the issue and ended up working around it. I agree the issue is still present

@GarrickBrown
Copy link

Thanks @JeremiahChurch, it is unfortunate as it's working so well otherwise

@nihey
Copy link
Contributor

nihey commented May 13, 2020

Just an update on this issue, I was able to fix this issue by adding a key into the track fill that toggles with the "disabled" prop. KasselLabs@02817ab

It is not the ideal solution but worked out with minimal impact.

But even though it worked, we've used our classNames solution on our fork in the end. Just sharing the knowledge in case anyone is having it too.

@iozbeyli
Copy link
Owner

iozbeyli commented Mar 16, 2021

This issue should be fixed by 0.7.1.

Issue caused by using background for disabled style instead of backgroundColor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants