Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: CMake, CI, macOS/Windows support, packaging, scan-build #109

Merged

Conversation

alessandrogario
Copy link

Things included in this PR:

  • macOS + Windows compatibility changes
  • macOS + Linux + Windows CI, based on GitHub Actions
  • CMake-based build system (suitable for importing the library as a submodule)
  • A scan-build job, uploading the report as artifact
  • Packaging (deb/rpm/tgz for Linux, tgz for macOS and Windows)

Things missing in GitHub Actions

  • Running the test framework (blocker I experienced: running the deprecated Python 2 test framework on a recent system)
  • Uploading the coverage data (CMake settings to generate it is already implemented)

@alessandrogario alessandrogario force-pushed the alessandro/build/add-cmake-support branch from 17c3d4a to 5f97959 Compare June 16, 2022 16:42
@Alan-Jowett
Copy link
Collaborator

OK, looks like the old build and new build both work. Merging it now.

@Alan-Jowett Alan-Jowett merged commit 48e526d into iovisor:master Jun 18, 2022
@alessandrogario alessandrogario deleted the alessandro/build/add-cmake-support branch June 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants