Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BIP-39 #929

Closed
3 tasks
husio opened this issue Jul 31, 2019 · 2 comments
Closed
3 tasks

Implement BIP-39 #929

husio opened this issue Jul 31, 2019 · 2 comments

Comments

@husio
Copy link
Contributor

husio commented Jul 31, 2019

As developer, I want to implement BIP 39 spec instead of using https://github.com/tyler-smith/go-bip39, so that we do not have to rely on inconsistent and abandoned software with bugs.

This issue is a result of learnings from implementing mnemonic support in bnscli. Used bip-39 package contains bugs and it is not updated for more than a year. If we have time, we should consider either fork & fix or implementing the spec from scratch.

Acceptance criteria

@ruseinov
Copy link
Contributor

@kmw101
Copy link
Contributor

kmw101 commented Aug 13, 2019

Not required as the bnscli is not going to be launched to mainnet

@kmw101 kmw101 closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants