Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return bnsd version on abci_info #1194

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Return bnsd version on abci_info #1194

wants to merge 6 commits into from

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Apr 1, 2020

Resolves #1174

@orkunkl orkunkl requested a review from davepuchyr April 1, 2020 17:10
davepuchyr
davepuchyr previously requested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@davepuchyr davepuchyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking along the lines of the commit hash as the version. What do you think of that?

@orkunkl
Copy link
Contributor Author

orkunkl commented Apr 2, 2020

I was thinking along the lines of the commit hash as the version. What do you think of that?

It is not possible because tendermint requires the app version to be an unsigned integer.

@orkunkl orkunkl requested a review from davepuchyr April 2, 2020 13:00
@davepuchyr davepuchyr dismissed their stale review April 2, 2020 13:03

My change request was not possible.

@davepuchyr davepuchyr self-requested a review April 2, 2020 13:16
davepuchyr
davepuchyr previously approved these changes Apr 2, 2020
View reviewed changes
@davepuchyr davepuchyr dismissed their stale review April 2, 2020 16:29

Integration with exchangenet failed.

@davepuchyr davepuchyr self-requested a review April 2, 2020 16:30
@davepuchyr davepuchyr mentioned this pull request Apr 14, 2020
Open
@davepuchyr davepuchyr removed their request for review July 27, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepuchyr davepuchyr davepuchyr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bnsd version to abci_info response
2 participants
@orkunkl @davepuchyr