Error in WaitForStateAsync is not wrapped

[avorima]

Description

The error in this line is neither wrapped nor even formatted correctly which means that it cannot be handled.

Additionally, the waitForStateWithChanel has a typo and the async wait for state or deletion code has a few issues. Code execution continues past writing of the done and state channels. For example here:

if err != nil {
	ch <- StateChannel{
		"",
		fmt.Errorf("error occured when calling the fn function", err),
	}
	done <- true
        // code execution should not go past this point
}

This pattern is found throughout the waitForStateWithChanel and waitForDeletionWithChannel functions. waitForDeletionWithChannel even has a risk of NPE because the apiResponse that is checked for nil here is then dereferenced a few lines after it. waitForStateWithChanel has the issue that it will hang when an error occurs. A message is sent to the done channel here and eventually another gets sent here. This means that this function will never exit since the exit condition done is checked on the next iteration and write to the done channel is blocked by it's size of 1.

This can be prevent by simply adding some continues or using an else block.

See: https://go.dev/play/p/0ENsyvFU4Bf

The code looks auto-generated so I don't know if I should contribute a patch. Please let me know.

[gabi-ionos]

Hello, thanks for noticing I will take a look into it.

[Ntr0]

Please note that the missing error wrapping affects all Wait* methods.

[gabi-ionos]

can you be more specific, please? Are you referring to the fact that the error should be a specific type of error(like a waitForErr of type err) to figure out what type of error is and from where that error was thrown?

[gabi-ionos]

The bug was solved and the new implementation will be able in the next release.
If anybody want to contribute to the sdk go, I think is ok to open a pull request to the sdk-go, and I will add the code in the files that are generating the sdk.

[avorima]

@gabisavu-ionos The issue still isn't resolved in the current master. When will the next release land?

[gabi-ionos]

The release is not made yet, I'm not sure when the release will be made, but I can inform you through a comment here or a message on chat.

[avorima]

Could we keep this issue open until the fix is done?

[gabi-ionos]

yes, sure

[avorima]

Thanks

[piepmatz]

Can be closed as https://github.com/ionos-cloud/sdk-go/releases/tag/v6.1.2 is out, I guess.

[avorima]

The release also has issues but at least it addressed the ones mentioned here.