Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpBlocks.GetItems should return IpBlock Slice, not pointer to IpBlock Slice #21

Open
Ntr0 opened this issue Feb 10, 2022 · 2 comments
Open

Comments

@Ntr0
Copy link

Ntr0 commented Feb 10, 2022

The function's comment states that the zero value of []IpBlock should be returned if Items is nil. Why can't we then return a slice instead of a slice pointer?

// If the value is explicit nil, the zero value for []IpBlock will be returned

@Ntr0
Copy link
Author

Ntr0 commented Feb 10, 2022

I'd like to add that all Getters should not return pointers to something unless explicitly required, as this makes the sdk painful to use.

@cristiGuranIonos
Copy link
Contributor

Thanks, makes sense, I think this would be a breaking change. We will prioritize appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants