Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup issue referencing external npm package #1551

Closed
fredcicles opened this issue May 20, 2019 · 11 comments
Closed

Rollup issue referencing external npm package #1551

fredcicles opened this issue May 20, 2019 · 11 comments
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time

Comments

@fredcicles
Copy link

fredcicles commented May 20, 2019

Stencil version:

 @stencil/core@1.0.0-beta.0

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
I get the following error and warning when I perform 'npm start'.

[ ERROR ] Rollup: Invalid External Id
'C:\Code\ui-ux\heatmap\node_modules@stencil\core\dist\sys\src\empty.js' is imported as an external by
C:\Code\ui-ux\heatmap\node_modules@stencil\core\dist\sys\src\empty.js?commonjs-proxy, but is already an
existing non-external module id.

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'C:\Code\ui-ux\heatmap\node_modules@stencil\core\dist\sys\src\empty.js' is imported by
C:\Code\ui-ux\heatmap\node_modules@stencil\core\dist\sys\src\empty.js?commonjs-proxy, but could not be
resolved – treating it as an external dependency

Steps to reproduce:
I have installed @amcharts4, which is when the issue arises. I upgraded to beta 0 from 0.16.3 where I was not seeing this issue and the amcharts4 controls worked properly.

@ionitron-bot ionitron-bot bot added the triage label May 20, 2019
@peterennis
Copy link
Contributor

FYI #1551
#1535

NOTE: rollup/rollup#2865

Supposed to be fixed with the new release of rollup

@fredcicles
Copy link
Author

How do I get that? It currently is not a dependency on the project, so I am guessing that just installing it would not do the trick.

@peterennis
Copy link
Contributor

@fredcicles
Copy link
Author

I did install the beta 2 but got the exact same exception.

@fredcicles
Copy link
Author

@manucorporat I am using @amcharts4. Let me know how I can provide you a repo case and will gladly do so.

@fredcicles
Copy link
Author

heatmap-one.zip
@manucorporat Here is a very basic project that I created. It has issues with the rollup.

@fredcicles
Copy link
Author

rollup/rollup#2726
leads me to believe that the version of rollup being used by stenciljs is out of date. He says that this issue is addressed in rollup v 1.32 and it appears to me that stencil beta 2 is using rollup version 1.12.3.

@simonhaenisch simonhaenisch changed the title Roolup issue referencing external npm package Rollup issue referencing external npm package May 21, 2019
@simonhaenisch simonhaenisch added bug and removed triage labels May 21, 2019
@simonhaenisch
Copy link
Contributor

@fredcicles the fix is in rollup version 1.12.3 (see the tag next to the branch info in the blue box at rollup/rollup@9f84980). I'll take a look at your repro.

@jpchip
Copy link

jpchip commented Jun 4, 2019

I created a project recreating the specific problem from #495, but seems relevant here:

https://github.com/jpchip/stencil-socketio

@jpchip
Copy link

jpchip commented Jun 7, 2019

@fredcicles Your issue might be resolved in v1.0.1, it resolved #495 for me.

@ionitron-bot ionitron-bot bot added the ionitron: stale issue This issue has not seen any activity for a long period of time label Jul 7, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Jul 7, 2019

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Jul 7, 2019
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time
Projects
None yet
Development

No branches or pull requests

4 participants