Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rollup configuration overrides #1489

Closed
liron-navon opened this issue May 1, 2019 · 4 comments
Closed

Allow rollup configuration overrides #1489

liron-navon opened this issue May 1, 2019 · 4 comments
Labels

Comments

@liron-navon
Copy link

Stencil version:

 @stencil/core@0.18.1

I'm submitting a:

[ ] bug report
[X ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
I have issues with stencil when I'm trying to use a monorepo, it would be helpful if we can supply a custom rollup setup to handle different (rollup issues).

Expected behavior:
Allow having a custom rollup configuration file

@ionitron-bot ionitron-bot bot added the triage label May 1, 2019
@Matthew-Smith
Copy link
Contributor

This would likely help resolve issues around rollup plugin loading order:
#1305 (comment)

@liron-navon
Copy link
Author

@Matthew-Smith
I added another issue, this one is a feature request, but the other is the actual bug which brought me to request it, #1491

I'm used to working with webpack and a lot of packages which use it like "storybook" or "vue" gives some way to extend it with custom configurations, so I think there is a need for it here, though I have no idea why you picked rollup instead of webpack/parcel, it's complicated and have a lot of issues 🤔

@nborelli
Copy link

nborelli commented May 8, 2019

I am also running into problems when trying to rollup a library that breaks when rollup freezes the module. It would help to add the freeze option to the RollupOutputOptions interface in Stencil 1. This would be the same as the Rollup CLI switch "--no-freeze" to prevent the freezing of namespace objects.

From Rollup docs: https://rollupjs.org/guide/en#core-functionality

output.freeze
Type: boolean
CLI: --freeze/--no-freeze
Default: true

Whether to Object.freeze() namespace import objects (i.e. import * as namespaceImportObject from...) that are accessed dynamically.

@adrianschmidt
Copy link

adrianschmidt commented May 29, 2019

I would like to configure rollup to treat a specific node module as an external dependency, so it doesn't include that in my build output. I can't find any information that indicates Stencil would currently let me do that? Unless there is already a way to do that, the requested feature should resolve the problem I'm facing.

Edit: After a quick test, the issue I'm facing doesn't appear in Stencil One beta 5. I still think exposing the rollup config would probably be a good idea though 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants