Skip to content

test(picker-column-internal): emit ionChange on scroll #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Flaky e2e test

What is the current behavior?

The test for validating that ionChange is emitting when ion-picker-column-internal is scrolled, will occasionally fail.

What is the new behavior?

  • Scroll the element to the bottom of the container to force ionChange to emit consistently

Does this introduce a breaking change?

  • Yes
  • No

Other information

I had issues with getting the test case to fail prior (locally). Ran the updated test 10+ times with passing results. Will see if it passes in CI as well.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@sean-perkins sean-perkins requested a review from a team March 25, 2022 00:00
@github-actions github-actions bot added the package: core @ionic/core package label Mar 25, 2022
@sean-perkins sean-perkins merged commit 136b8ec into main Mar 29, 2022
@sean-perkins sean-perkins deleted the FW-1069 branch March 29, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants