Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): only preventDefault for the onClick event #22573

Merged
merged 4 commits into from Nov 25, 2020
Merged

fix(a11y): only preventDefault for the onClick event #22573

merged 4 commits into from Nov 25, 2020

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Nov 25, 2020 •
edited by liamdebeasi

resolves #22557

@github-actions github-actions bot added the package: core @ionic/core package label Nov 25, 2020
@brandyscarney brandyscarney changed the title fix(checkbox): only prevent default for the onClick event fix(a11y): only preventDefault for the onClick event Nov 25, 2020
@brandyscarney brandyscarney merged commit 0786835 into master Nov 25, 2020
@brandyscarney brandyscarney deleted the fix-checkbox-event-prop branch November 25, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ion-item click event not triggering if item contains checkbox
1 participant
@brandyscarney