Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): fix @types/react to avoid 16.14.1 release #22554

Merged
merged 1 commit into from Nov 23, 2020
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There was an issue in @types/react@16.14.1 (DefinitelyTyped/DefinitelyTyped#49713) that caused build errors when trying to build Ionic React. This PR fixes the version to 16.14.0 until a fix is released.

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: react @ionic/react package label Nov 23, 2020
@liamdebeasi liamdebeasi changed the title chore(): fix @types/react to avoid buggy 16.14.1 release chore(): fix @types/react to avoid 16.14.1 release Nov 23, 2020
@liamdebeasi liamdebeasi merged commit a664ccb into master Nov 23, 2020
@liamdebeasi liamdebeasi deleted the react-type branch November 23, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant