Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): testing a routerLink-capable component no longer warns of missing router dependency #22532

Merged
merged 3 commits into from Nov 23, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22506

What is the new behavior?

  • We check to see if the nav manager has been provided to the app
  • If it has, we proceed as normal when the routerLink-capable component has been clicked
  • Otherwise we warn the user about the lack of routing capabilities and return

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Nov 19, 2020
@liamdebeasi liamdebeasi force-pushed the vue-test-router branch 2 times, most recently from 87067d9 to 5ac2e3f Compare November 19, 2020 22:01
@github-actions github-actions bot added package: core @ionic/core package and removed package: core @ionic/core package labels Nov 19, 2020
@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Vue unit tests - remove hard requirement of a navManager injection when not using any navigation
1 participant