Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): title attribute is automatically inherited #22493

Merged
merged 5 commits into from Nov 13, 2020
Merged

fix(input): title attribute is automatically inherited #22493

merged 5 commits into from Nov 13, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22055

What is the new behavior?

  • title attr is inherited on input and textarea

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 12, 2020
brandyscarney
brandyscarney reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

core/src/utils/helpers.ts Outdated Show resolved Hide resolved
@liamdebeasi @brandyscarney
Update core/src/utils/helpers.ts
cd58d45 
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi liamdebeasi merged commit abad12f into master Nov 13, 2020
@liamdebeasi liamdebeasi mentioned this pull request Nov 13, 2020
Closed
@liamdebeasi liamdebeasi deleted the inherit-attr branch November 13, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add title property to input
2 participants
@liamdebeasi @brandyscarney