Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backdrop): nvda no longer incorrectly announces backdrop #22481

Merged
merged 2 commits into from Nov 16, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22102

What is the new behavior?

  • NVDA reads the backdrop as clickable since it has an onClick listener. However, this causes NVDA to announce "clickable" when the popover opens which is confusing
  • Where users cannot tab to the backdrop, we chose to remove the backdrop from the screen reader tree entirely

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 11, 2020
@brandyscarney
Copy link
Member

How do users close the popover without being able to click the backdrop?

@liamdebeasi
Copy link
Contributor Author

How do users close the popover without being able to click the backdrop?

Users currently cannot dismiss a popover unless the popover dismisses when selecting a button. We need a better way to handle this but need to do more research first in order to implement this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Content of the ion popover is read as clickable
2 participants