Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): correctly pass route props to components #22476

Merged
merged 1 commit into from Nov 11, 2020
Merged

fix(vue): correctly pass route props to components #22476

merged 1 commit into from Nov 11, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22472

What is the new behavior?

  • Pass route props when rendering components

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 11, 2020
@liamdebeasi liamdebeasi merged commit 0956f8b into master Nov 11, 2020
@liamdebeasi liamdebeasi deleted the vue-pass-props branch November 11, 2020 17:12
@liamdebeasi liamdebeasi mentioned this pull request Nov 11, 2020
Closed
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
@liamdebeasi
fix(vue): correctly pass route props to components (ionic-team#22476)
0b71789 
resolves ionic-team#22472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Vue: ion-router-outlet not passing Route Props
1 participant
@liamdebeasi