Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-content will-change: transform causing issues #22473

Closed
gabsgasps opened this issue Nov 10, 2020 · 6 comments · Fixed by #22489
Closed

bug: ion-content will-change: transform causing issues #22473

gabsgasps opened this issue Nov 10, 2020 · 6 comments · Fixed by #22489
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@gabsgasps
Copy link

gabsgasps commented Nov 10, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
In recent modification in content.scss, the property 'position: fixed' stopped working correctly.

And when I remove 'transform' it works correctly

but it can be overwritten by:

ion-content::part(scroll) {
     will-change: scroll-position;
}

Related code:
repository: https://github.com/gabsgasps/bug-positionfixed

Other information:
I would like help because I don't know why it happens, I managed to solve it by overwriting the css, but it doesn't make sense for a property to cause this.

Ionic info:

Ionic:

   Ionic CLI                     : 6.12.1
   Ionic Framework               : @ionic/angular 5.4.3
   @angular-devkit/build-angular : 0.1000.8
   @angular-devkit/schematics    : 10.0.8
   @angular/cli                  : 10.0.8
   @ionic/angular-toolkit        : 2.3.3

Capacitor:

   Capacitor CLI   : 2.4.2
   @capacitor/core : 2.4.2

Utility:

   cordova-res : not installed
   native-run  : 0.3.0

System:

   NodeJS : v12.18.4
   npm    : 6.14.8
   OS     : Windows 10
@ionitron-bot ionitron-bot bot added the triage label Nov 10, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This looks like a difference in how Chromium handles scrolling + compositing vs WebKit. I will make the fix in 9f44966 more specific so it only affects devices with WebKit.

@liamdebeasi
Copy link
Contributor

Actually the Chromium behavior is correct according to the spec: https://bugs.chromium.org/p/chromium/issues/detail?id=413456

And WebKit has an open issue to fix the behavior in their engine: https://bugs.webkit.org/show_bug.cgi?id=167600

So will-change: transform is probably not a good solution here in general. I will remove that and find another solution for #22180.

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Nov 11, 2020
@liamdebeasi liamdebeasi added this to the 5.5.0 milestone Nov 11, 2020
@ionitron-bot ionitron-bot bot removed the triage label Nov 11, 2020
@liamdebeasi liamdebeasi changed the title bug: 'position: fixed' not working okay within Ion-Content bug: ion-content will-change: transform causing issues Nov 11, 2020
@liamdebeasi
Copy link
Contributor

Can you try the following dev build and let me know if it resolves the issue?

npm install @ionic/angular@5.5.0-dev.202011121513.0956f8b

@gabsgasps
Copy link
Author

@liamdebeasi I tested and it's resolved

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #22489, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 12, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
2 participants