Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): tab bar now works with slot="top" #22461

Merged
merged 3 commits into from Nov 10, 2020
Merged

fix(vue): tab bar now works with slot="top" #22461

merged 3 commits into from Nov 10, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22456

What is the new behavior?

  • We now add the tab bar to the DOM before tabs-inner if it is supposed to be slotted on top.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 9, 2020
@liamdebeasi liamdebeasi changed the title fix(vue): tab bar can now works with slot="top" fix(vue): tab bar now works with slot="top" Nov 10, 2020
@liamdebeasi liamdebeasi merged commit e17c822 into master Nov 10, 2020
@liamdebeasi liamdebeasi mentioned this pull request Nov 10, 2020
Closed
@liamdebeasi liamdebeasi deleted the vue-slot-top branch November 10, 2020 15:07
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
@liamdebeasi
fix(vue): tab bar now works with slot="top" (ionic-team#22461)
771b226 
resolves ionic-team#22456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ionic vue tab-bar slot="top" not working
1 participant
@liamdebeasi